search

filamentphp / filamentphp.com

Source code for the filamentphp.com website.
https://filamentphp.com
186 stars 244 forks source link

Smoother search animation by adding debounce to search input. #468

Closed abdelhamiderrahmouni closed 2 months ago

abdelhamiderrahmouni commented 2 months ago

I've added 500ms debounce modifier to the search input in both articles and plugins search pages to give room to the animation to play smoothly.

HassanZahirnia commented 2 months ago

Thanks for submitting a PR, but unfortunately I'm against this debounce value.

This creates an unnecessary delay which is a bad UX in my opinion. We're loading all the plugins data in-memory and there is no back-end trip, which let us have insta search and other features. This PR basically kills that value we getting.

abdelhamiderrahmouni commented 2 months ago

Thank you for the feedback. I didn't have a clear idea about the way you handle search! certainly i didn't know about this possibility before (loading all the elements to memory) and i find it clever, so thank you for your hard work on this project👍🏻.