search

filamentphp / filamentphp.com

Source code for the filamentphp.com website.
https://filamentphp.com
186 stars 244 forks source link

[Plugin] Filament 2FA #509

Closed Baspa closed 3 weeks ago

Baspa commented 1 month ago

Hey @saade, I fixed the URLs in the package and also changed the image in this PR. It's a PNG, is that a problem? Or do you want me to convert it to a JPG?

saade commented 3 weeks ago

Hey @saade, I fixed the URLs in the package and also changed the image in this PR. It's a PNG, is that a problem? Or do you want me to convert it to a JPG?

not a problem.

Baspa commented 3 weeks ago

Hey! Could you please ensure that image URLs in your plugin's README file are absolute URLs rather than relative links? Then we can embed them on our website correctly. Thanks!

Please let us know when you've addressed these issues.

I believe all images are already absolute URLs right now?

saade commented 3 weeks ago

They're not, here's an example of a raw url https://raw.githubusercontent.com/vormkracht10/filament-2fa/main/docs/two-factor-page.png

Baspa commented 3 weeks ago

Ah excuse me, didn't know that. I fixed them! @saade