filamentphp / filamentphp.com

Source code for the filamentphp.com website.
https://filamentphp.com
186 stars 244 forks source link

Docs partner header #523

Closed zepfietje closed 3 weeks ago

zepfietje commented 1 month ago

As previously discussed (@danharrin), this PR adds a note about the partners to the docs header just like on the Laravel site. It randomly shows either Kirschbaum or Whizzy on every page load:

Screenshot 2024-08-29 at 17 41 41 Screenshot 2024-08-29 at 17 41 49
danharrin commented 1 month ago

Please add a close button with local storage persistence for your preference

zepfietje commented 1 month ago

What would the close button be needed for? Wouldn't that defeat the purpose of the banner?

danharrin commented 1 month ago

I think the banner is pretty distracting and the user should at least have a choice to regain that screen real estate

zepfietje commented 1 month ago

What about just scrolling it out of view?

danharrin commented 1 month ago

The docs navbar is sticky, so is that possible?

zepfietje commented 1 month ago

Yeah, I moved it out of the header element so the banner scrolls away :)

zepfietje commented 3 weeks ago

This is ready to go now, @danharrin 🙂