search

filbertkm / android-protips-location

Automatically exported from code.google.com/p/android-protips-location
0 stars 0 forks source link

Eclair-specific code is broken #9

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
It looks like there are a couple of issues with the Eclair-specific code:

1) The booleans to enable/disable the services in the manifest file are 
reversed:

<service android:enabled="@bool/pre_froyo" 
android:name=".services.PlacesUpdateService"> and <service 
android:enabled="@bool/froyo_or_later" 
android:name=".services.EclairPlacesUpdateService">

should be

<service android:enabled="@bool/froyo_or_later" 
android:name=".services.PlacesUpdateService"> and <service 
android:enabled="@bool/pre_froyo" 
android:name=".services.EclairPlacesUpdateService">

2) Several classes do

PlacesConstants.SUPPORTS_ECLAIR ? EclairPlacesUpdateService.class : 
PlacesUpdateService.class

but should do 

PlacesConstants.SUPPORTS_FROYO ? PlacesUpdateService.class : 
EclairPlacesUpdateService.class

3) LegacyPlacesUpdateRequester is never instantiated in 
PlatformSpecificImplementationFactory.getLocationUpdateRequester()

Original issue reported on code.google.com by lit...@gmail.com on 5 Oct 2011 at 11:23