filbertphang / pe

0 stars 0 forks source link

Undo/Redo: Unhelpful messages #10

Open filbertphang opened 1 year ago

filbertphang commented 1 year ago

Upon a successful undo/redo command, the only result provided is "undo success" or "redo success". However, the actual action that was undoed/redoed is not explained, so users do not know what has actually changed.

This problem is especially notable when we consider that appointments and policies can also be undoed/redoed, so it is not immediately obvious what change has been undone/redone.

soc-pe-bot commented 1 year ago

Team's Response

Background: We implemented undo/redo as stated in DG which is using list of history of client book (address book). So there is no record of what specific command the user do. Moreover, it would cause significant memory overhead if we store command history just to show info

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: - The rationale provided only explains why this feature is not currently implemented, and not why this feature SHOULD NOT be implemented. Just because it is implemented in a particular way currently does not mean that it should not be implemented in a different/better way.

If anything, the rationale provided implies that the team feels like this bug should be classified as "Not in scope", rather than "Rejected".


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** No justification provided for downgrading the severity. In my opinion, this is quite a significant feature flaw as users may not exactly remember all the changes that they made. So any undos past the most recent one would likely lead to confusion. If the team wanted to downgrade the severity, they should have justified why the current state of undo/redo messages should be sufficient for the user.