Mac Support

[ShalokShalom]

While a Linux user, I also have access to the Macbook of my girlfriend. I would like to help, and can imagine to provide images, or at least confirm dotherside working. I plan to use it with the Nim binding, so we could add support there as well.

Currently, I am stuck at this issue: https://github.com/filcuc/dotherside/issues/105

I can also imagine to install Qt5. And I think it is even cleaner, to prepare for Qt6, since it is suggested to be simple and I assume that it`s healthy for our adoption rate.

Wonderful work, thanks! 😄

[filcuc]

@ShalokShalom i've just opened https://github.com/filcuc/dotherside/pull/113 for fixing #105

[filcuc]

@ShalokShalom Qt6 support has been added let me know if mac support is working...i don't expect major problems

[ShalokShalom]

Here my output

qmake -v
QMake version 3.1
Using Qt version 6.3.1 in /usr/local/lib
build ) cmake .. 
-- The C compiler identification is AppleClang 13.1.6.13160021
-- The CXX compiler identification is AppleClang 13.1.6.13160021
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE  
-- Performing Test HAVE_STDATOMIC
-- Performing Test HAVE_STDATOMIC - Success
-- Found WrapAtomic: TRUE  
-- Found OpenGL: /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/System/Library/Frameworks/OpenGL.framework   
-- Found WrapOpenGL: TRUE  
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) 
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/linda/.projekte/dotherside/build
build ) make install
[  3%] Automatic MOC for target DOtherSide
[  3%] Built target DOtherSide_autogen
[  6%] Building CXX object lib/CMakeFiles/DOtherSide.dir/DOtherSide_autogen/mocs_compilation.cpp.o
[  9%] Building CXX object lib/CMakeFiles/DOtherSide.dir/src/DOtherSide.cpp.o
In file included from /Users/linda/.projekte/dotherside/lib/src/DOtherSide.cpp:38:
In file included from /Users/linda/.projekte/dotherside/lib/include/DOtherSide/DOtherSideTypesCpp.h:30:
/Users/linda/.projekte/dotherside/lib/include/DOtherSide/Utils.h:87:62: error: 'result_of<(lambda at /Users/linda/.projekte/dotherside/lib/src/DOtherSide.cpp:556:27) (void *)>' is deprecated [-Werror,-Wdeprecated-declarations]
template <typename T, typename K, typename R = typename std::result_of<K(T)>::type>
                                                             ^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/type_traits:4009:34: note: 'result_of<(lambda at /Users/linda/.projekte/dotherside/lib/src/DOtherSide.cpp:556:27) (void *)>' has been explicitly marked deprecated here
template <class _Callable> class _LIBCPP_DEPRECATED_IN_CXX17 result_of;
                                 ^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__config:1066:39: note: expanded from macro '_LIBCPP_DEPRECATED_IN_CXX17'
#  define _LIBCPP_DEPRECATED_IN_CXX17 _LIBCPP_DEPRECATED
                                      ^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__config:1043:48: note: expanded from macro '_LIBCPP_DEPRECATED'
#    define _LIBCPP_DEPRECATED __attribute__ ((deprecated))
                                               ^
1 error generated.
make[2]: *** [lib/CMakeFiles/DOtherSide.dir/src/DOtherSide.cpp.o] Error 1
make[1]: *** [lib/CMakeFiles/DOtherSide.dir/all] Error 2
make: *** [all] Error 2
build ) 

[filcuc]

Ok the problem is that on gcc I enabled to consider warning as errors and the c++ std::result_of has been deprecated in c++17. The only solution would be to use a sort of ifdef for splitting the path when compiling on c++17. But imho this seems overkill and I would simply remove to threat warnings as errors.

Il giorno ven 12 ago 2022 alle 12:40 ShalokShalom @.***> ha scritto:

Here my output

qmake -v QMake version 3.1 Using Qt version 6.3.1 in /usr/local/lib build ) cmake .. -- The C compiler identification is AppleClang 13.1.6.13160021 -- The CXX compiler identification is AppleClang 13.1.6.13160021 -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc - skipped -- Detecting C compile features -- Detecting C compile features - done -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++ - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done -- Performing Test CMAKE_HAVE_LIBC_PTHREAD -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success -- Found Threads: TRUE -- Performing Test HAVE_STDATOMIC -- Performing Test HAVE_STDATOMIC - Success -- Found WrapAtomic: TRUE -- Found OpenGL: /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/System/Library/Frameworks/OpenGL.framework -- Found WrapOpenGL: TRUE -- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) -- Configuring done -- Generating done -- Build files have been written to: /Users/linda/.projekte/dotherside/build build ) make install [ 3%] Automatic MOC for target DOtherSide [ 3%] Built target DOtherSide_autogen [ 6%] Building CXX object lib/CMakeFiles/DOtherSide.dir/DOtherSide_autogen/mocs_compilation.cpp.o [ 9%] Building CXX object lib/CMakeFiles/DOtherSide.dir/src/DOtherSide.cpp.o In file included from /Users/linda/.projekte/dotherside/lib/src/DOtherSide.cpp:38: In file included from /Users/linda/.projekte/dotherside/lib/include/DOtherSide/DOtherSideTypesCpp.h:30: /Users/linda/.projekte/dotherside/lib/include/DOtherSide/Utils.h:87:62: error: 'result_of<(lambda at /Users/linda/.projekte/dotherside/lib/src/DOtherSide.cpp:556:27) (void )>' is deprecated [-Werror,-Wdeprecated-declarations] template <typename T, typename K, typename R = typename std::result_of<K(T)>::type> ^ /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/type_traits:4009:34: note: 'result_of<(lambda at /Users/linda/.projekte/dotherside/lib/src/DOtherSide.cpp:556:27) (void )>' has been explicitly marked deprecated here template class _LIBCPP_DEPRECATED_IN_CXX17 result_of; ^ /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__config:1066:39: note: expanded from macro '_LIBCPP_DEPRECATED_IN_CXX17'

define _LIBCPP_DEPRECATED_IN_CXX17 _LIBCPP_DEPRECATED

                                  ^

/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__config:1043:48: note: expanded from macro '_LIBCPP_DEPRECATED'

define _LIBCPP_DEPRECATED attribute ((deprecated))

                                           ^

1 error generated. make[2]: [lib/CMakeFiles/DOtherSide.dir/src/DOtherSide.cpp.o] Error 1 make[1]: [lib/CMakeFiles/DOtherSide.dir/all] Error 2 make: *** [all] Error 2 build )

— Reply to this email directly, view it on GitHub https://github.com/filcuc/dotherside/issues/112#issuecomment-1212972566, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWTXI4QVSPGUKAQ4PJDNZLVYYS27ANCNFSM552ESKMQ . You are receiving this because you commented.Message ID: @.***>

-- Filippo Cucchetto

[ShalokShalom]

So, if I understood you right, you are going to change that warnings are considered as errors, yes?

Can you report on me, once this is done?

[filcuc]

@ShalokShalom added conditional code for the invoke_result/result_of