Improvements - Githubissues

fildaw / traveltime-internship-task

0 stars 0 forks source link

Improvements #2

Closed fildaw closed 1 month ago

fildaw commented 1 month ago

Improved error handling in main,
Removed most of the mutable variables,
Rebuilt the function assigning locations to regions,
Added new type holding the results,
Added error related to bad longitude (now it should be in range [-360,360]),
Improved error messages,
Fixed an unclosed polygon test.

PKJonas commented 1 month ago

Just a small procedural comment for the future: I would split up the PR into smaller self-contained PRs. E.g. making the other coord constructor return a Result caused you to add a lot of .unwrap()s in tests, cluttering up a PR which does other things as well. Splitting it off would make it easier to review all the changes.