search

file-icons / DevOpicons

Heavily-optimised version of the Devicons icon-font.
https://vorillaz.github.io/devicons/
132 stars 23 forks source link

Git icon details #4

Closed bersace closed 3 years ago

bersace commented 4 years ago

Hi,

Here is a comparison between DevOpicon and all-the-icon

image

DevOpicon is better sized and positionned, but all-the-icon is easier with commit node a bit larger. Especially when background and foreground colors are bright.

image

What do you think of this ? Would it be possible to improve git icon ?

Thanks for DevOpicons.

Alhadis commented 4 years ago

I'm not sure what all-the-icons is using for its Git icon, but it appears they've modified certain details of the original/official icon (whereas ours matches the exact details of the original).

Modifying icon details to be clearer at tiny resolutions isn't something I'm averse to, but I am reluctant to modify icons that have been in-use for a long time. People get used to seeing the originals, and are sometimes bothered when noticeable changes are introduced without rhyme or reason. Hence why I try to avoid it when I can.

bersace commented 4 years ago

That's fair. Is DevOpicons popular enough to be as conservative ?

Alhadis commented 4 years ago

It's used in the file-icons package for Atom, so yes, most certainly.