search

file-icons / atom

Atom file-specific icons for improved visual grepping.
MIT License
1.31k stars 250 forks source link

Install fails (maximum callstack exceeded) #788

Closed nerdyman closed 4 years ago

nerdyman commented 4 years ago

Hi,

I previously had file-icons installed but the package broke when trying to upgrade to file-icons@2.1.35, removing/reinstalling doesn't fix the issue.

This is the output from apm install file-icons

Installing file-icons to /home/me/.atom/packages /usr/lib/node_modules/atom-package-manager/node_modules/graceful-fs/graceful-fs.js:194
    if (this instanceof ReadStream)
             ^

RangeError: Maximum call stack size exceeded
    at Function.[Symbol.hasInstance] (<anonymous>)
    at ReadStream (/usr/lib/node_modules/atom-package-manager/node_modules/graceful-fs/graceful-fs.js:194:14)
    at ReadStream (/usr/lib/node_modules/atom-package-manager/node_modules/graceful-fs/graceful-fs.js:195:28)
    at ReadStream (/usr/lib/node_modules/atom-package-manager/node_modules/graceful-fs/graceful-fs.js:195:28)
    at ReadStream (/usr/lib/node_modules/atom-package-manager/node_modules/graceful-fs/graceful-fs.js:195:28)
    at ReadStream (/usr/lib/node_modules/atom-package-manager/node_modules/graceful-fs/graceful-fs.js:195:28)
    at ReadStream (/usr/lib/node_modules/atom-package-manager/node_modules/graceful-fs/graceful-fs.js:195:28)
    at ReadStream (/usr/lib/node_modules/atom-package-manager/node_modules/graceful-fs/graceful-fs.js:195:28)
    at ReadStream (/usr/lib/node_modules/atom-package-manager/node_modules/graceful-fs/graceful-fs.js:195:28)
    at ReadStream (/usr/lib/node_modules/atom-package-manager/node_modules/graceful-fs/graceful-fs.js:195:28)

I'm using Node 11.15.0.

Alhadis commented 4 years ago

This seems to be an upstream issue with Atom's package manager, which occasionally barfs under certain network condition.

Your best bet is to file a report there, as this issue really isn't something we have any control over.

nerdyman commented 4 years ago

OK cool I'll take a look at the APM issues, thanks for the quick response!

gavsiu commented 4 years ago

I had this exact issue when I was using Atom 1.39.1. The issue is gone with 1.40.1.

Alhadis commented 4 years ago

Definitely an upstream issue, or something related to your environment. Heck, I don't think there have even been any package updates between those two releases...

gavsiu commented 4 years ago

If it makes a difference, I had the atom 1.39.1-1 package in the Arch Linux Community repo installed. I uninstalled it and installed atom-editor-bin 1.40.1-1 from AUR.

Alhadis commented 4 years ago

There's no official port of Atom for Arch Linux, meaning that what you were using is maintained by the community, rather than the Atom team.

So if the problem appears to be with that build, I'd suggest bringing it up with the users maintaining the port. 😉

nerdyman commented 4 years ago

Yep, my bad, I'm using Arch too. Arch's Atom has been flagged as out of date, it's still on 1.39.1-1. https://www.archlinux.org/packages/community/x86_64/atom/