file-icons / atom

Atom file-specific icons for improved visual grepping.
MIT License
1.31k stars 250 forks source link

Valve icon and extension #799

Closed Wanty5883 closed 4 years ago

Wanty5883 commented 4 years ago

Would be very nice to add some Valve Source Engine file support. Unfortunately there isn't much icon around for those file type.

BSP   - Binary Space Partition    - .bsp
VPK   - Valve Package             - .vpk .vtfx
VMT   - Valve Material Format     - .vmt
VTF   - Valve Texture Format      - .vtf
VMF   - Valve Map Format          - .vmf
RES   - Resource List             - .res

As they are specific files to Valve game engine, it would be a good idea to keep the Valve logo and put file extension beside it ? I made a little example (poorly made) so you might get a better idea of what I have in mind.

Valve-source-logo

Also thanks for this Atom package. Helps a lot. I wish could contribute myself adding more icon and new file extension. I was reading the different readme but I didn't catch what to do next adding content to the project.

Alhadis commented 4 years ago

The device in the Source logo should be enough. I'll add it, but our release cycle is roughly once-a-month, so it wouldn't

I wish could contribute myself adding more icon and new file extension. I was reading the different readme but I didn't catch what to do next adding content to the project.

See CONTRIBUTING.md. However, adding an icon is a procedure I prefer to handle myself, as most SVGs in the wild need touching-up to work as an icon. I also make a point of eliminating excess geometry in the process, which requires a certain attention to detail (as well as above-average competence with graphics software). To use this as an example:

cmp

Even if users have the editing skill, I don't expect them to have the time and/or patience needed to clean up some of the more extreme cases (such as Lerna's icon):

cmp2

The difficulties of these procedures are largely why I encourage people to submit a request, rather than a PR, since I'll need to optimise the icon anyway. Hence I've never written up a contribution guide for adding an icon.

Wanty5883 commented 4 years ago

Well having the name beside it would be really handy. Most of the time in Source Engine folder files are mixed up. So having file extension on the icon would help a lot. Can also find files that are not specific to Source Engine

Alhadis commented 4 years ago

We use colour variations to distinguish different formats with the same icon. Putting the extension in the icon itself isn't a good design choice, since it adds visual clutter and repeats what's already visible in the filename anyway.

I just finished adding the filetype mappings, so you'll see the colours with the next package release:

"Valve Source Engine":
    icon: "source"
    match: [
        [".bsp", "medium-orange", alias: "Binary Space Partition", signature: /^VBSP/]
        [".vpk", "medium-red", alias: /^Valve (Package|Pak)$/i, signature: /^4\x12\xAAU./]
        [".vtfx", "dark-red", signature: /^VTFX/]
        [".vmt", "medium-blue", alias: "Valve Material Type", scope: "vmt"]
        [".vtf", "dark-blue", alias: /^Valve Texture (File|Format)$/i, signature: /^VTF\0|^\0FTV/]
        [".vmf", "medium-maroon", alias: /^Valve Map (File|Format)$/i, uses: "XML"]
        [".res", "medium-cyan", alias: /^Resource List$/i]
    ]
Wanty5883 commented 4 years ago

Awesome ! Should I create more issues to list some file name, extension, icons in the future ? I mess around video game modding, so I do see various file type. I'd be glad to help on this project

Thanks for your fast response !

Alhadis commented 4 years ago

Yep, go nuts.