search

file-icons / atom

Atom file-specific icons for improved visual grepping.
MIT License
1.32k stars 250 forks source link

Change coffee-script to coffeescript #826

Closed spenserblack closed 4 years ago

spenserblack commented 4 years ago

Sorry for spamming PRs 😅 but I figured different "subjects" should be separated into different PRs.

coffee-script has been deprecated, and moved to coffeescript, so this PR basically just removes the hyphen.

Alhadis commented 4 years ago

I'd actually prefer not to upgrade CoffeeScript. Literally all it's being used for is recompiling the config.cson file, which Atom's usual CSON converter can't handle because it doesn't support regular expressions for some reason.

Upgrading the module not only solves nothing, but actually opens the potential for something to wrong regarding dependencies or versioning issues.

spenserblack commented 4 years ago

That makes sense. This isn't necessarily an upgrade, though -- it's still CoffeeScript, just not using the deprecated package name, and thus no warning on npm install.

If you're using the deprecated package name to prevent versions beyond 1.12.7 from being installed, ^1.12.7 could be changed to =1.12.7 to force that exact version to be installed.

Alhadis commented 4 years ago

^1.12.7 could be changed to =1.12.7 to force that exact version to be installed.

Would that silence the warning though?

spenserblack commented 4 years ago

Ah, sorry, I meant changing to =1.12.7 and changing to coffeelint. Changing to coffeelint silences the warning. Since the highest version published under coffee-lint before it was deprecated seems to be 1.12.7, "coffee-lint": "^1.12.7" is effectively the same as "coffee-lint": "=1.12.7".

If you want to switch to coffeelint to silence the warning, but stay at the same version you have been using, the full change would be "coffee-lint": "^1.12.7" to "coffeelint": "=1.12.7".