file-icons / atom

Atom file-specific icons for improved visual grepping.
MIT License
1.31k stars 251 forks source link

Add support for license-PREFIX #883

Closed spenserblack closed 1 year ago

spenserblack commented 1 year ago

There are +19.2k files that follow the format license-PREFIX.

+13k of these are LICENSE-MIT or LICENSE-APACHE, which is a very common dual-license in the Rust ecosystem.

Right now this change change has indefinite variations, but, that this could be limited to two variations and satisfy the majority, perhaps this proposed change should be simplified to only check these two prefixes.

To do

If this is merged as-is with indefinite variations, I suppose I'll have to also add some of the most common as manual fixes to the vscode repository :slightly_smiling_face:

spenserblack commented 1 year ago

Oops, I should have read the regex more clearly and tested it out first. It already does match these files. Sorry for the spam.

Alhadis commented 1 year ago

@spenserblack Haha, all good mate. The reason you're not seeing this in VS Code is because of the inherit limitations of its icon-themes: it can only map icons by file-extension or unabridged filename. 😞

spenserblack commented 1 year ago

Thanks! I'll do some research into the most popular -FOO suffixes and make a PR to the vscode repo to add them to the "missing filenames" file if that sounds good. If I understood correctly, that should add the icons to LICENSE-MIT, LICENSE-APACHE, etc. if they're hardcoded in that file, right?

No rush, but speaking about VS Code, is there a rough ETA for the next release? This is absolutely the prettiest icon theme IMO :slightly_smiling_face: The more files with icons, the prettier :laughing:

Alhadis commented 1 year ago

No rush, but speaking about VS Code, is there a rough ETA for the next release?

Damn, I thought I already cut a release. 🤔 So these changes have been sitting here for over a year… completely unpublished. 😅

Let me see what I can do.

Alhadis commented 1 year ago

Currently trying to figure out what the hell's going on over at marketplace.visualstudio.com. 😖 This error message is—in classic Microsoft fashion—equal parts frustrating and uninformative.

Figure 1
Alhadis commented 1 year ago

Right. After several days of hair-pulling and loud profanity, I figured out what was wrong: turns out I wasn't including LICENSE.md in the packaged *.vsix (something which wasn't a problem before, but was clearly introduced as a new headache in some new VSCode release).

@spenserblack You should now see v1.1.0 available for download in VS Code. 👍 Let me know if anything looks awry.

spenserblack commented 1 year ago

Awesome, thanks!

Alhadis commented 1 year ago

No problem! 😀 Again, I'm sorry the release took over a fucking year. This should give you an indication as to how chaotic my workspace is at the moment… 😞