search

file-icons / vscode

VSCode file specific icons for improved visual grepping
https://marketplace.visualstudio.com/items?itemName=file-icons.file-icons
MIT License
191 stars 24 forks source link

two small patches to fix #11 and #13 #18

Closed costela closed 6 years ago

costela commented 6 years ago

the fix for #13 seems to indicate that all other fileNames entries should probably be lower-case. A short search in the code seems to confirm this (the filename gets converted to lower-case before searching for a match).

DanBrooker commented 6 years ago

Hi @costela

I've included your fix for Dockerfile's to the script that generates the theme.json files, thanks for figuring that out. See c62b019795ba8dea624cddcadc055d81189b7078

As for the folder icon change, could you create a new PR with just that change by editing the import script scripts/import.js instead of directly editing the theme.json files.

Thanks, Dan