search

file-icons / vscode

VSCode file specific icons for improved visual grepping
https://marketplace.visualstudio.com/items?itemName=file-icons.file-icons
MIT License
191 stars 24 forks source link

Update some icons #5

Closed abdonrd closed 7 years ago

abdonrd commented 7 years ago

I attach images VSCode vs Atom:

screen shot 2017-02-10 at 19 47 19 screen shot 2017-02-10 at 19 47 54 screen shot 2017-02-10 at 19 48 17
DanBrooker commented 7 years ago

Latest version has the new atom icons. README.md is just getting the markdown icon because of the rule precedence in vscode not sure I can do much about that.

abdonrd commented 7 years ago

Thanks! :)

abdonrd commented 7 years ago

Oops! The polymer.json and the Static files are with other icons:

screen shot 2017-02-11 at 02 12 43
abdonrd commented 7 years ago

Friendly ping to @DanBrooker. :)

DanBrooker commented 7 years ago

Hey, I haven't had time to fix this yet, but it's the same issue as with the other icons, where vscode seems to prioritise file extension over file name. I'll open a new issue explaining this and close the issues that have the same issue.

PRs welcome if you wanted to try fix it :)

DanBrooker commented 7 years ago

See #10

abdonrd commented 7 years ago

Got it, thanks Daniel!