/opt/filebot-node/task: 18: Bad substitution

KnifeFed commented 2 years ago

When the image was updated the other day (can't really pinpoint it because there are no releases or changelogs *hint hint* 😉), both my filebot-node and filebot-xpra containers stopped working. It seems that paths were changed in the config directory..? I deleted my current config directories so new ones were created. Xpra works again and the node tasks appear to work fine, except they produce the error message stated in the title. This happens with all my previous tasks as well as new ones I just tried creating. Here's log output from running one:

$ curl "http://<IP>:<PORT>/task?id=1"
/opt/filebot-node/task 1

------------------------------------------

Run script [fn:amc] at [Tue Oct 12 17:32:23 CEST 2021]
Parameter: ut_label = Movie
Parameter: music = y
Parameter: unsorted = y
Parameter: clean = y
Parameter: skipExtract = y
Parameter: excludeList = .excludes
Argument[0]: /path/dl
Use excludes: /path/lib/.excludes (0)
No files selected for processing
Done ¯\_(ツ)_/¯
/opt/filebot-node/task: 18: Bad substitution

------------------------------------------

[Process error]

🔺 Exit Code: 2

💡 You may evaluate FileBot Node by using [Dry Run] instead of [Execute]

rednoah commented 2 years ago

Good catch. Looks like /bin/sh isn't bash. Fixed with https://github.com/filebot/filebot-docker/commit/c476d140176751b6c04cd2ce821024ad22aa25f4

rednoah commented 2 years ago

You can restore the old behaviour of running everything as root via -e PUID=0, otherwise the container will now downgrade to a normal user, and use per-user $HOME directories to avoid permissions issues: https://github.com/filebot/filebot-docker/blob/master/generic/opt/bin/run-as-user

KnifeFed commented 2 years ago

Thanks for the quick fix!

I'm actually running both containers as 99:100 now, the default Unraid user, so thanks for that feature too!

filebot / filebot-docker

/opt/filebot-node/task: 18: Bad substitution #13