filebrowser / caddy

:floppy_disk: File Browser Caddy plugins.
https://caddyserver.com/docs/http.filebrowser
Apache License 2.0
27 stars 11 forks source link

Use filebrowser/dev to run tests, build caddy #5

Closed eine closed 6 years ago

eine commented 6 years ago

As commented in 1#, this PR uses docker image filebrowser/dev to run all the tests. Also, a stage is added where caddy is built, in order to ensure that plugins are properly embedded.

There are some issues I am not sure about:

hacdias commented 6 years ago

I don't know what gofmt and goimport do.

gofmt formats the code. gomimport updates the import lines if something is missing or removing unused ones.

Should we enable vendoring and add vendor to the cache...?

I don't believe it's needed.

Do we need to run gometalinter ./...? Is not gometaliner enough?

Yes, gometalinter ./... is needed.

Do we need to test against tip?

No, but let's always use the latest Go version.

eine commented 6 years ago

gofmt formats the code. gomimport updates the import lines if something is missing or removing unused ones.

Without ./... some of the files were not being processed. It works as expected now.

No, but let's always use the latest Go version.

The latest stable one (golang:alpine) or the beta (golang:rc-alpine)?

hacdias commented 6 years ago

Stable 😄