filebrowser / docs

📄 Who doesn't like documentation?
58 stars 39 forks source link

Fixing docker example command for latest alpine image #44

Open psolru opened 2 years ago

psolru commented 2 years ago

While checking out filebrowser, I just noticed the database file is in the latest version of the alpine image in the same location as for the non-alpine image.
/database/filebrowser.db

This simply adjusts the example docker run command of the install docs

slinkytoad commented 1 year ago

I just got stumped by this. Would be nice to have the PR merged to update the docs.

o1egl commented 1 year ago

That is not correct. The default config file for docker points to the /filebrowser.db

HackintoshwithUbuntu commented 12 months ago

That is not correct. The default config file for docker points to the /filebrowser.db

The default config points to filebrowser.db but the docker command maps a file on the local filesystem called filebrowser.db to one on the docker container's file system called database.db

To fix this we can either update the default config to expect a file called "database.db" or do what this PR suggested and update the docker command so that a file called "filebrowser.db" appears on the container file system

For what its worth, my install on docker did not work out of the box and these fixes were required.

o1egl commented 11 months ago

That is not correct. The default config file for docker points to the /filebrowser.db

The default config points to filebrowser.db but the docker command maps a file on the local filesystem called filebrowser.db to one on the docker container's file system called database.db

To fix this we can either update the default config to expect a file called "database.db" or do what this PR suggested and update the docker command so that a file called "filebrowser.db" appears on the container file system

For what its worth, my install on docker did not work out of the box and these fixes were required.

I'm not sure I'm following you. This is the default database path https://github.com/filebrowser/filebrowser/blob/master/docker_config.json#L6C30-L6C30

HackintoshwithUbuntu commented 11 months ago

I'm not sure I'm following you. This is the default database path https://github.com/filebrowser/filebrowser/blob/master/docker_config.json#L6C30-L6C30

I think the confusion is arising because we are referencing two different files.

  1. I was talking about https://github.com/filebrowser/filebrowser/blob/master/docker/root/defaults/settings.json which is listed on the official installation guide here
  2. In the previous comment you have linked https://github.com/filebrowser/filebrowser/blob/master/docker_config.json

I think you would probably have a more in-depth knowledge than me about which file is actually being used

o1egl commented 11 months ago

I'm not sure I'm following you. This is the default database path https://github.com/filebrowser/filebrowser/blob/master/docker_config.json#L6C30-L6C30

I think the confusion is arising because we are referencing two different files.

  1. I was talking about https://github.com/filebrowser/filebrowser/blob/master/docker/root/defaults/settings.json which is listed on the official installation guide here
  2. In the previous comment you have linked https://github.com/filebrowser/filebrowser/blob/master/docker_config.json

I think you would probably have a more in-depth knowledge than me about which file is actually being used

You are referrencing a linuxserver based image config, but actually changing a regular docker file. It uses docker_config.json which points to the /database.db

HackintoshwithUbuntu commented 11 months ago

I'm not sure I'm following you. This is the default database path https://github.com/filebrowser/filebrowser/blob/master/docker_config.json#L6C30-L6C30

I think the confusion is arising because we are referencing two different files.

  1. I was talking about https://github.com/filebrowser/filebrowser/blob/master/docker/root/defaults/settings.json which is listed on the official installation guide here
  2. In the previous comment you have linked https://github.com/filebrowser/filebrowser/blob/master/docker_config.json

I think you would probably have a more in-depth knowledge than me about which file is actually being used

You are referrencing a linuxserver based image config, but actually changing a regular docker file. It uses docker_config.json which points to the /database.db

My apologies, I understand now. Thanks for the clarification.