search

filecoin-project / Allocator-Governance

7 stars 28 forks source link

Community Review of Marshall Allocator #138

Open filecoin-watchdog opened 3 weeks ago

filecoin-watchdog commented 3 weeks ago

Allocator Compliance Report: https://compliance.allocator.tech/report/f03012911/1724112525/report.md

Example 1: https://github.com/Marshall-btc/Marshall-Fil-Data-Pathway/issues/1

KYC shared in comments - ask gov team to follow up if needed

Public Open Dataset

SPs provided: f03074583
f03074586
f03074587
f03074589
f03074592

CID report: https://check.allocator.tech/report/Marshall-btc/Marshall-Fil-Data-Pathway/issues/1/1721956008799.md SPs used for deals: Provider Location Total Deals Sealed Percentage Unique Data Duplicate Deals Mean Spark Retrieval Success Rate 7d f03055005 Hong Kong, Hong Kong, HK China Unicom Global 177.94 TiB 35.61% 171.72 TiB 3.49% 0.00% f01315096 Hong Kong, Hong Kong, HK China Unicom Global 51.31 TiB 10.27% 50.47 TiB 1.64% 0.00% f03091739 Dallas, Texas, US Flexential Colorado Corp. 93.84 TiB 18.78% 93.75 TiB 0.10% 0.00% f03144037 Paripark, Seoul, KR The Constant Company, LLC 176.59 TiB 35.34% 176.59 TiB 0.00% 8.57%

No SPs match original list Retrievals are low across SPs taking deals

Client received 1.3PiBs over 2 allocations

filecoin-watchdog commented 3 weeks ago

Example 2 https://github.com/Marshall-btc/Marshall-Fil-Data-Pathway/issues/3 Example 3 https://github.com/Marshall-btc/Marshall-Fil-Data-Pathway/issues/5

SPs given do not match Retrievals low, client still given additional 1PIB of Data

Small group of SPs storing 80% of deals

filecoin-watchdog commented 3 weeks ago

Across all 3 applications, there is no detail on data preparation, all questions in the applications are left blank. I'd challenge the allocator to push for more details and demonstrate proof of how dataset is prepared and documented and how the client can actually retrieve the open files.

There is no questioning of dataset size and total DataCap calculations - I would ask the allocator / clients to justify the amount they are asking. The totals being requested do not match the amounts of the Dataset * the # of copies

Marshall-btc commented 2 weeks ago

I have read the question posed by filecoin-watchdog and wish to respond here.

  1. Retrieval Success Rate I have consistently regarded retrieval as a key issue and believe that the retrieval success rate is a crucial metric. In the fourth round of Fil+ rules, Boost retrieval rate was one of the metrics tested, and now we are more concerned about Spark retrieval rate. In the previous Allocator quota refresh process, Spark was identified as a new retrieval method that requires further study to adapt to different sizes of SPs, particularly for small and medium-sized SPs, which presents a challenge. However, it is evident that the overall retrieval rate of Spark is gradually improving. Please refer to the attached screenshots for more details. image image image image
Marshall-btc commented 2 weeks ago
  1. The list of actual participating SPs does not appear in the client application. I identified this issue at the outset of data distribution and have been in communication with the client on GitHub. It seems that the data encapsulation process primarily focuses on the coin staking of prime SPs. The SPs disclosed in the application are those with whom the client had communicated and cooperated at the time of application. However, due to the pledged coins and other uncontrollable factors, some of these SPs could not be encapsulated in a timely manner. In such cases, the client would contact other SPs. I have asked the client to update the information and provide the necessary explanations in the application. image image image

As with these screenshots, I'll be reminding clients that they need to keep their GitHub comments up to date if the SP changes. image

Marshall-btc commented 2 weeks ago
  1. Some information was not completed in the client's application. As you stated, some information is missing from the client's DataCap application. However, as an Allocator, I believe I have the authority to ask additional questions. As illustrated in the attached screenshot, I also pose queries to clients regarding data preparation in the comments section. image

In addition, I believe that Marshall Allocator has some promising aspects. Upon application, I request KYC/KYB verification from each client. They subsequently provide the requisite supporting documents, which I can also forward to the Fil+ Gov team if needed. Please find below some KYC/KYB screenshots. image image image

Marshall-btc commented 1 week ago

I attended today's FIL+ governance meeting and will continue to run allocator in compliance with the official rules and look forward to getting official 10PiB support! @galen-mcandrew @Kevin-FF-USA Thank you very much ！

galen-mcandrew commented 6 days ago

Given the above information and additional investigation, this allocator is working to perform diligence and intervene with their clients to enforce compliance. We want to call attention to some specific issues that should be addressed with existing and new clients going forward, specifically:

As a reminder, the allocator team is responsible for verifying, supporting, and intervening with their clients. If a client is NOT providing accurate deal-making info (such as incomplete or inaccurate SP details) or making deals with noncompliant unretrievable SPs, then the allocator needs to intervene and require client updates before more DataCap should be awarded.

Despite the flags above, we are seeing evidence of allocator diligence and interventions. We are requesting an additional 5PiB of DataCap from RKH, to allow this allocator to show increased diligence and alignment.

Please verify that you will instruct, support, and require your clients to work with retrievable storage providers. @Marshall-btc can you verify that you will enforce retrieval requirements, such as through Spark?

Marshall-btc commented 4 days ago

Thank you for your reply @galen-mcandrew . I will pay more attention to Allocator compliance such as Spark retrieval, KYC/KYB audit process. Improve communication with clients. Regarding the VPN issue, I will have another communication with the client. Anyway thanks a lot and let's work together in the future.