filecoin-project / Allocator-Governance

7 stars 36 forks source link

3rd Community Diligence Review of ByteBase (Destore) Allocator #219

Open Destore2023 opened 2 weeks ago

Destore2023 commented 2 weeks ago

This ronud we have allocated to four clients. https://github.com/Destore2023/MetaPathways-Bookkeeping/issues/16 https://github.com/Destore2023/MetaPathways-Bookkeeping/issues/18 (New client) https://github.com/Destore2023/MetaPathways-Bookkeeping/issues/21 (New client) https://github.com/Destore2023/MetaPathways-Bookkeeping/issues/24 (New client)

These clients are currently in process. Before allocation, we did due diligence on them - using a self-designed questionnaire to collect clients' information. https://github.com/Destore2023/MetaPathways-Bookkeeping/issues/18#issuecomment-2443650842 image

https://github.com/Destore2023/MetaPathways-Bookkeeping/issues/21#issuecomment-2449427884 image

https://github.com/Destore2023/MetaPathways-Bookkeeping/issues/24#issuecomment-2453386468 image

Clients provide their latest SP list regularly.

  1. SP list https://github.com/Destore2023/MetaPathways-Bookkeeping/issues/16#issuecomment-2461439884 Retrieval https://check.allocator.tech/report/Destore2023/MetaPathways-Bookkeeping/issues/16/1727346611052.md

  2. SP list https://github.com/Destore2023/MetaPathways-Bookkeeping/issues/18#issuecomment-2461258164 Retrieval https://check.allocator.tech/report/Destore2023/MetaPathways-Bookkeeping/issues/18/1730354139198.md

  3. SP list https://github.com/Destore2023/MetaPathways-Bookkeeping/issues/21#issuecomment-2456732494 Retrieval https://check.allocator.tech/report/Destore2023/MetaPathways-Bookkeeping/issues/21/1730800520859.md

  4. SP list https://github.com/Destore2023/MetaPathways-Bookkeeping/issues/24#issuecomment-2461511658 Retrieval (no report) image

We actively check the success rate of retrieval for our clients. Client had asked me for help about retrieval and I helped them talk with spark team. https://github.com/filecoin-station/spark/issues/100 image

We will keep our process up-to-date and provide feedback on github repo. We will make our work more detailed and better. Hope to get a new round of 20P DataCap for further work. Thanks!

filecoin-watchdog commented 2 days ago

@Destore2023 Allocator Application
Compliance Report
1st Review
2nd Review
1st Review score: 5PiB 2nd Review score: 10PiB

7.75 PiB granted to existing clients: Client Name DC status
NationalRenewable Energy Laboratory 2.25PiB New
NationalRenewable Energy Laboratory 1.5PiB New
NationalLibrary of Medicine 1.5PiB New
SpaceTelescope Science Institute. 0.5PiB New
NOAA 2PiB Existing

NationalRenewable Energy Laboratory

NationalRenewable Energy Laboratory

NationalLibrary of Medicine

SpaceTelescope Science Institute.

NOAA

Destore2023 commented 8 hours ago

Hello @filecoin-watchdog, thanks for the review.

https://github.com/Destore2023/MetaPathways-Bookkeeping/issues/18

Since the client's weekly allocation of datacap requested is 256TiB, this issue is allocated according to the way of LDN in the past.

As we prepared to sign for the second round of approvals, we found that something may go wrong with the program. We did the signing action in ledger and didn't see anything to show us that the allocation had been successful. We think we've got a bug. So we were searching the channel https://github.com/fidlabs/allocator-tooling/ and found that someone had experienced the same problem that time. image This should be an bug generated by program updating. It wasn't until we went to check later that we realized datacap had been successfully allocated without notice on application and allocator.tech. Since this client's first round of package was good, we didn't take back the extra allocated datacap.

The client used all the DC they got, but there are only 9 replicas instead of the declared 10.

I see from the report that this client distributed to 10 sps. Please have a check. https://check.allocator.tech/report/Destore2023/MetaPathways-Bookkeeping/issues/18/1732126166582.md image

About retrieval, we have asked this client and made an issue for them. https://github.com/filecoin-station/spark/issues/100 image image

Most SPs match provided list (this address wasn’t used for deals: f01084941, and this one wasn’t updated in the issue yet was used for deals: f01975299)

Confirmed with this client, who had just worked with this sp. image

https://github.com/Destore2023/MetaPathways-Bookkeeping/issues/21 Thanks for your tips. We had gone to confirm and found that only one client seems to have successfully completed the storage of this dataset in the past. And we noticed that this dataset is updating, so we accept clients to store this dataset.

Those two clients even had the same issues: https://github.com/Destore2023/MetaPathways-Bookkeeping/issues/18#issuecomment-2449486407 vs. https://github.com/Destore2023/MetaPathways-Bookkeeping/issues/21#issuecomment-2453361400

I think it's because the sp they are having problems with is the same one. We think that clients have different abilities and are limited in the number of sp that can be contacted. Clients are able to find qualified partners for cooperation from a limited number of active sps, which we support.

The client gave me feedback on the progress made in the retrieval. image Also feedback on the problems they are facing. image That's why we've doubled the distribution.

https://github.com/Destore2023/MetaPathways-Bookkeeping/issues/24

The allocator correctly noted that the data prepared by the client was already stored on the filecoin. However, the client should have specified more precisely what data he plans to store, providing a narrowed scope of data.

Thanks for your tips.

2SPs don’t match the provided list.

I will push my clients to update their sp lists as soon.

https://github.com/Destore2023/MetaPathways-Bookkeeping/issues/29 Considering the varied capabilities of our clients, we currently allocate our clients according to their weekly allocation requirements as the way of LDN.

https://github.com/Destore2023/MetaPathways-Bookkeeping/issues/16 image Clients said that they had replaced sp due to cost. This is the reason why the number of sps is higher than the planned number.

Thanks again for the review, it makes us realize that there are some aspects of our review that need to be improved. We will try our best to do better!