FIP-0086 updates from implementation

anorth commented 2 months ago

Two notable changes feeding back from the implementation, plus some smaller improvements:

There is not (yet) any mechanism to slow F3 if EC is producing only empty tipsets
The mayHaveStrongQuorum function is changed to treat boundary conditions "correctly"
Described F3 committee lookback
Specified filters to power table eligibility (TODO: confirm with @Stebalien, especially around ticket math)
Specified power scaling/truncation
Specified values for step numbers

Tightened up some language and formatting:

Removed some unnecessary phrases.
Removed lingering tab characters.
Unified commenting style in pseudocode to use //.
Replaced some academic argument-style language (especially use of"we") with declarative statements.

A potentially clarifying change we could make would be a change in terminology from power table & power (EC concepts) to committee and weight (F3 concepts). These terms are currently a bit ambiguous since the concepts are not 1:1. I refrained for now.

anorth commented 2 months ago

Thanks for the contributions @masih @Stebalien.

This PR is ready for editorial and detailed technical review, and then merging.

jennijuju commented 1 month ago

editorial ✅

jsoares commented 1 month ago

I'm hoping to still read through today, assuming it's not merged before.

filecoin-project / FIPs

FIP-0086 updates from implementation #1022