filecoin-project / FIPs

The Filecoin Improvement Proposal repository
312 stars 166 forks source link

Common Node API #1027

Open ansermino opened 2 months ago

ansermino commented 2 months ago

A work-in-progress to establish a common API for all node implementations.

Many todos remain at this point, most notably:

jennijuju commented 2 months ago

@filecoin-project/lotus-maintainers 👀 plz

Stebalien commented 2 months ago

IMO, this should go under the FRC section instead of the FIP section as it's not a consensus critical change (and therefore doesn't have to go through the entire FIP process).

jennijuju commented 2 months ago

I am supportive of the motivation and direction of this proposal. Will give a more thorough review once the methods list are proposed

Stebalien commented 2 months ago

FWIW, I think this is a great idea.

aatifsyed commented 2 months ago

IMO, this should go under the FRC section instead of the FIP section as it's not a consensus critical change (and therefore doesn't have to go through the entire FIP process).

@Stebalien We chose to be a technical FIP based on this guidance: https://github.com/filecoin-project/FIPs/blob/020bcb412ee20a2879b4a710337959c51b938d3b/FIPS/fip-0001.md?plain=1#L30

Happy to move to FRC if that fits better - maybe the above could be amended?

ansermino commented 2 months ago

I am supportive of the motivation and direction of this proposal. Will give a more thorough review once the methods list are proposed

🙏 @jennijuju

We have a working doc with all the methods here: https://docs.google.com/spreadsheets/d/1fFkQuEjvFAd2s1dGX5zGmhxsEMLMUZ4uQFnIXgSZA5w/edit?usp=sharing

A few methods we're still unsure of, but we've taken a stance of most of them. Rationale is included for those that are excluded, and those that are included should fit into one of the categories we describe

BigLep commented 2 months ago

Since GitHub didn't backlink it, the accompanying discussion for this PR is https://github.com/filecoin-project/FIPs/discussions/1032