search

filecoin-project / FIPs

The Filecoin Improvement Proposal repository
312 stars 166 forks source link

FIP-0086 Audit final changes #996

Closed ranchalp closed 4 months ago

ranchalp commented 4 months ago

Addressing design issues listed as ii. (partially) iii. iv. and vi. from go-f3's #177.

jsoares commented 4 months ago

@Kubuxu @masih @Stebalien just signalling this to you; covers the noted items in https://github.com/filecoin-project/go-f3/issues/177

ranchalp commented 4 months ago

This looks good to me (just note the outstanding question from @anorth).

Did I not already addressed that comment (you mean this one I guess?) (I did not accept the commit suggestion, but made it in a new commit myself, as I was considering other changes).

Should we also include the proofs pdf in this PR?

We can. I have just accepted suggestions on the two docs that are IMO at their final versions (GossiPBFT Implementation v2, and GossiPBFT message rebroadcast v3, with the former referencing the later in a new section). Lmk if you would like me to do it or if you are waiting on Alex North or others to agree to this before doing it yourself (or have me do it). 🙂

jsoares commented 4 months ago

Did I not already addressed that comment (you mean https://github.com/filecoin-project/FIPs/pull/996#discussion_r1592942134 I guess?) (I did not accept the commit suggestion, but made it in a new commit myself, as I was considering other changes).

You hadn't when I started the review -- you had by the time I submitted it. I just resolved the discussion, no further action needed.

Let's sync in slack re pdfs.