filecoin-project / bellperson

zk-SNARK library
Other
191 stars 120 forks source link

GPU name with colon not able to set with BELLMAN_CUSTOM_GPU #253

Closed Eliovp closed 2 years ago

Eliovp commented 2 years ago
`022-01-11T22:24:02.140 INFO bellperson::gpu::fft > FFT: 3 working device(s) selected.
2022-01-11T22:24:02.140 INFO bellperson::gpu::fft > FFT: Device 0: gfx1011:xnack-
2022-01-11T22:24:02.140 INFO bellperson::gpu::fft > FFT: Device 1: gfx906:sramecc-:xnack-
2022-01-11T22:24:02.140 INFO bellperson::gpu::fft > FFT: Device 2: gfx906:sramecc-:xnack-
2022-01-11T22:24:02.140 INFO bellperson::domain > GPU FFT kernel instantiated!
2022-01-11T22:24:02.209 INFO bellperson::gpu::locks > GPU is available for Multiexp!
2022-01-11T22:24:02.209 WARN bellperson::gpu::utils > Number of CUDA cores for your device (gfx1011:xnack-) is unknown! Best performance is only achieved when the number of CUDA cores is known! You can find the instructions on how to support custom GPUs here: https://lotu.sh/en+hardware-mining
2022-01-11T22:24:02.209 INFO bellperson::gpu::program > Using kernel on OpenCL.
2022-01-11T22:24:02.219 WARN bellperson::gpu::utils > Number of CUDA cores for your device (gfx906:sramecc-:xnack-) is unknown! Best performance is only achieved when the number of CUDA cores is known! You can find the instructions on how to support custom GPUs here: https://lotu.sh/en+hardware-mining
2022-01-11T22:24:02.219 INFO bellperson::gpu::program > Using kernel on OpenCL.
2022-01-11T22:24:02.228 WARN bellperson::gpu::utils > Number of CUDA cores for your device (gfx906:sramecc-:xnack-) is unknown! Best performance is only achieved when the number of CUDA cores is known! You can find the instructions on how to support custom GPUs here: https://lotu.sh/en+hardware-mining
2022-01-11T22:24:02.228 INFO bellperson::gpu::program > Using kernel on OpenCL.`

"your device (gfx906:sramecc-:xnack-) is unknown!"

Setting gfx906:sramecc-:xnack- is not possible due to the name already having a colon in it for obvious reasons. export BELLMAN_CUSTOM_GPU="gfx906:sramecc-:xnack-:3840"

- Rust panic: Invalid BELLMAN_CUSTOM_GPU!

Solution: ability to escape characters or put a check in for a integer after the colon.

vmx commented 2 years ago

This was fixed by the merge of https://github.com/filecoin-project/bellperson/pull/256.