search

filecoin-project / bellperson

zk-SNARK library
Other
191 stars 120 forks source link

refactor: use ec-gpu-gen for FFT and multiexp #261

Closed vmx closed 2 years ago

vmx commented 2 years ago

The FFT and multiexponentation calculations were refactored into a library called ec-gpu 1. Use that library now.

BREAKING CHANGE: RAYON_NUM_THREADS is split into two settings

The RAYON_NUM_THREADS variable used to control the total number of threads. It resulted in roughly two times as many threads. This setting is now split into RAYON_NUM_THREADS and EC_GPU_NUM_THREADS. The total number of threads will now roughly be those two settings combined.

EC_GPU_NUM_THREADS will control the number of threads used for FFT and multiexponentiation calculations.

Closes #259.

vmx commented 2 years ago

I've force pushed the change to use the released ec-gpu version instead of a Git dependency. A re-approval is needed.

Once approved, is it ready to be merged, or should we wait for other changes?