search

filecoin-project / bls-signatures

BLS Signatures in Rust
Other
74 stars 44 forks source link

Fix additive feature flag usage #37

Closed austinabell closed 3 years ago

austinabell commented 3 years ago

Very optional, I don't care if this comes in, but the features in the crate are not additive. This causes issues when a crate that depends on this needs to support each feature.

Also just fixes

cargo c --all-features

or any combination of features, which would fail to compile before. It doesn't indicate that it's using unnecessary dependencies, so I can add a compiler warning if that helps.

dignifiedquire commented 3 years ago

Thanks, but as mentioned on Slack, we don't want to merge this to avoid accidentally using both backends in the same built, as we have not tested that and can't gurantee things to work