search

filecoin-project / bls-signatures

BLS Signatures in Rust
Other
72 stars 43 forks source link

Fix benches #39

Closed koivunej closed 3 years ago

koivunej commented 3 years ago

Fixes build failures with the benches. Did not look when did the benches go stale, but issues were:

Added a ci run to make sure the benches do not go stale in the future. I'm not really so familiar with circleci so please review carefully. In the last commit I removed the whitespace errors git is nagging about (and my $EDITOR removes automatically).

I can't see xorshift => thread_rng() change being that important since none of the benched blocks includes rng use.

koivunej commented 3 years ago

Unsure why the checks don't seem to run, does it require review before running them as a cost saving measure?

This should not interfere with #37 however if it's to be merged before this, it might be a good idea to add --all-features to the ci check to avoid surprising issues with features being enabled in the future. It would stack more expectations on the check run, but it's a good one to test regardless.

dignifiedquire commented 3 years ago

CI didn't build because of a misconfiguration on CircleCI

dignifiedquire commented 3 years ago

if you could just push an empty commit, to trigger ci we should be good now

koivunej commented 3 years ago

Edited the last commit. I had forgotten about this and removed the working copy already. Do I see correctly that the master hasn't advanced in the meantime or am I just fumbling with the remotes?

dignifiedquire commented 3 years ago

looks all good, thank you!