search

filecoin-project / blstrs

Other
58 stars 37 forks source link

Revert "public R and Zero constants" #52

Closed nikkolasg closed 1 year ago

nikkolasg commented 1 year ago

This reverts commit da7e03873802316f4544107fa28b174f6261d809.

Sorry by mistake while playing with blstrs I pushed on main repo... on master. No big deal changes but I thought I'd revert it here and explain.

Pushing on master probably should be disabled tbh for the repo, or enforced via PR at least.

codecov-commenter commented 1 year ago

Codecov Report

Merging #52 (57d240d) into master (da7e038) will increase coverage by 0.01%. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/filecoin-project/blstrs/pull/52/graphs/tree.svg?width=650&height=150&src=pr&token=2TCP8TMM22&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)](https://codecov.io/gh/filecoin-project/blstrs/pull/52?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) ```diff @@ Coverage Diff @@ ## master #52 +/- ## ========================================== + Coverage 88.91% 88.92% +0.01% ========================================== Files 14 14 Lines 6727 6727 ========================================== + Hits 5981 5982 +1 + Misses 746 745 -1 ``` | [Impacted Files](https://codecov.io/gh/filecoin-project/blstrs/pull/52?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) | Coverage Δ | | |---|---|---| | [src/fp.rs](https://codecov.io/gh/filecoin-project/blstrs/pull/52?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-c3JjL2ZwLnJz) | `95.73% <ø> (+0.11%)` | :arrow_up: |