publish fund tagging doesn't take deals/msg into account

ghost commented 1 year ago

Checklist

[X] This is not a question or a support request. If you have any boost related questions, please ask in the discussion forum.
[X] This is not a new feature request. If it is, please file a feature request instead.
[X] This is not an enhancement request. If it is, please file a improvement suggestion instead.
[X] I have searched on the issue tracker and the discussion forum, and there is no existing related issue or discussion.
[X] I am running the Latest release, or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
[X] I did not make any code changes to boost.

Boost component

[X] boost daemon - storage providers
[ ] boost client
[X] boost UI
[ ] boost data-transfer
[ ] boost index-provider
[ ] Other

Boost Version

latest

Describe the Bug

boost tags funds per deal and not per message. based on lotus publish fee settings that tags way to many funds

[edit]

math was most likely off - sorry for the hastly issue. i think it goes way beyond a simple fix, even one would be appreciated.

if this is still a "thing" in around 3-4 weeks we will come back to this and make some more productive proposals on how to fix this (caught up in something else right now that needs the attention until then)

Logging Information

not needed

Repo Steps

Run '...'
Do '...'
See error '...' ...

ghost commented 1 year ago

a switch to turn off the feature would be a preferred quick fix.

LexLuthr commented 1 year ago

@f8-fil-ops We are planning to remove fund tagging. Either this feature will be re-written with different logic or removed all together. Unfortunately, I cannot commit any timeline for this.

https://github.com/filecoin-project/boost/issues/1320 is related to the same.

LexLuthr commented 1 year ago

Tagging can be turned off by setting MaxPublishDealsFee = “0.00 FIL”. When maxFee is set to 0, MpoolPushMessage will guess appropriate fee based on current chain conditions.

marshyonline commented 1 year ago

a switch to turn off the feature would be a preferred quick fix.

1+ on this - I spoke with @dirkmc yesterday and he agreed that a switch for this could be done. @dirkmc is this issue enough or would you like me to create another?

Setting the MaxFee to 0 is too risky - I don't want to pay 1.2FiL to publish 4 deals 😂

dirkmc commented 1 year ago

@marshyonline no need for another ticket. We will add a flag to turn off fund tagging.

I would like to get some more detail on how SPs make these calculations though, so we can improve the experience for people who choose to leave fund tagging on.

@marshyonline and @f8-fil-ops could you please post a comment with an example of how you calculate how much funds you will need to reserve to make a deal / batch of deals

ghost commented 1 year ago

we set the fees to the max amount we are willing to pay per deal, eg. 0.1 per deal, 100 deals = 10 FIL max fees. (see lotus setting for batching/aggregation)

everything from there we do by hand - eg. the basefee never goes low enough, we raise fee msg params to get the msg on chain

filecoin-project / boost