search

filecoin-project / builtin-actors

The Filecoin built-in actors
Other
78 stars 74 forks source link

Non Interactive Proof of Replication #1537

Closed NemanjaLu92 closed 1 week ago

NemanjaLu92 commented 2 months ago

See also https://github.com/filecoin-project/ref-fvm/pull/1999

rvagg commented 1 month ago

I had a go at documenting the constants in go-state-types here: https://github.com/filecoin-project/go-state-types/pull/270

I'd appreciate feedback on them to make sure I'm understanding and describing them well.

BigLep commented 2 weeks ago

For anyone watching this PR, the latest status discussions have been happening in https://filecoinproject.slack.com/archives/C06EZQ2DTD0/p1718256559056139

rvagg commented 2 weeks ago

Looking really good @NemanjaLu92! I've left a bunch of minor suggestions and some necessary changes inline.

BigLep commented 1 week ago

For transparency, audit findings are in https://docs.google.com/document/d/1tcUfqgeM-TsKhJcIozIg-RTD_iU2pK6x_I5hncchIaA/edit . Per 2024-06-18 discussion, there are additional items to address.

aarshkshah1992 commented 1 week ago

Should we close this PR now that https://github.com/filecoin-project/builtin-actors/pull/1559 is merged ?

rvagg commented 1 week ago

merged in https://github.com/filecoin-project/builtin-actors/pull/1559 🥳 thanks @NemanjaLu92 !