search

filecoin-project / builtin-actors

The Filecoin built-in actors
Other
81 stars 76 forks source link

fix: restore ConfirmSectorProofsValid #1553

Closed rvagg closed 3 months ago

rvagg commented 3 months ago

Removed in https://github.com/filecoin-project/builtin-actors/pull/1540 but I believe it's still needed to activate preseals; unless there's an alternative route to this?

Ref: https://github.com/filecoin-project/lotus/blob/b73d4e0481517b395a0e9aa9af5dab8bedc18285/chain/gen/genesis/miners.go#L494-L509

Tests for this were tangled up in the prove commit + cron stuff that was removed, this probably needs new tests if it's going back, but I'm not sure yet what that would entail.

aarshkshah1992 commented 3 months ago

@ZenGround0 @rvagg Should we merging this to the release/v14 branch instead ?

ZenGround0 commented 3 months ago

I haven't been so involved in the v14 release but the typical thing we've done here is merge changes to master first and then cherrypick them to the release branch.

BigLep commented 3 months ago

I'll file an issue to do the correct thing and get rid of this code in the future.

@ZenGround0 : please paste a link to that issue when you have it - thanks.

ZenGround0 commented 3 months ago

https://github.com/filecoin-project/builtin-actors/issues/1556

BigLep commented 3 months ago

@aarshkshah1992 or @ZenGround0 : as part of https://github.com/filecoin-project/lotus/pull/12132, can we get an approval on this change?

BigLep commented 3 months ago

Oh sorry, I realize @ZenGround0 alraedy gave an approval. @aarshkshah1992 : are you ok to merge?