filecoin-project / consensus

Filecoin consensus work
Other
42 stars 5 forks source link

Subtle and maybe wrong dependence among sim randomness #46

Closed ZenGround0 closed 5 years ago

ZenGround0 commented 5 years ago

In the sim we use the same random value for election proof and the block's new ticket. This goes against the protocol's separation of the two values (at least when lbp > 1). While using the same value might not matter it is possible the dependence between the two random values is causing weird and subtle effects in the simulation that might skew results in weird undetectable way.

It looks like randomness sampling is going to need to change to conform to the latest EC spec update anyway, so doing that ASAP and getting it right (i.e. mimicing the actual protocol and sampling 2 different values) is probably the best way to make sure things aren't weird.

sternhenri commented 5 years ago

fixed here: https://github.com/filecoin-project/consensus/commit/831edf9245240d0c0f610b1e845b86e7305c46b8