search

filecoin-project / cpp-filecoin

C++17 implementation of Filecoin
https://filecoin.io/
GNU General Public License v3.0
126 stars 36 forks source link

Feature/cbor map #542

Closed Alexey-N-Chernyshov closed 2 years ago

Alexey-N-Chernyshov commented 2 years ago

Description of the Change

Add cbor map with manual ordered (non canonical).

Benefits

Supports Lotus market encoding where signature depends on this wrong order.

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

codecov[bot] commented 2 years ago

Codecov Report

Merging #542 (f068e9a) into master (6693708) will increase coverage by 0.02%. The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #542      +/-   ##
==========================================
+ Coverage   46.41%   46.44%   +0.02%     
==========================================
  Files         679      679              
  Lines       30164    30185      +21     
  Branches    16723    16730       +7     
==========================================
+ Hits        14000    14018      +18     
- Misses      12120    12122       +2     
- Partials     4044     4045       +1
Impacted Files Coverage Δ
core/codec/cbor/cbor_encode_stream.hpp 93.10% <ø> (ø)
core/codec/cbor/cbor_encode_stream.cpp 97.11% <85.71%> (-2.89%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6693708...f068e9a. Read the comment docs.