search

filecoin-project / cpp-filecoin

C++17 implementation of Filecoin
https://filecoin.io/
GNU General Public License v3.0
126 stars 36 forks source link

Feature/wallet #565

Closed wer1st closed 2 years ago

wer1st commented 2 years ago

Description of the Change

Move wallet API methods to new Wallet entity. Introduce MultiWallet conception that allows us to work with multiple wallets by using one multi wallet. LedgerWallet has to be added in MultiWallet.

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

codecov[bot] commented 2 years ago

Codecov Report

Merging #565 (15d13a8) into master (f48a0cc) will increase coverage by 0.00%. The diff coverage is 10.15%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #565   +/-   ##
=======================================
  Coverage   46.61%   46.61%           
=======================================
  Files         682      685    +3     
  Lines       30896    30901    +5     
  Branches    17161    17162    +1     
=======================================
+ Hits        14402    14405    +3     
- Misses      12256    12258    +2     
  Partials     4238     4238
Impacted Files Coverage Δ
core/api/full_node/make.cpp 0.00% <0.00%> (ø)
core/api/network/network_api.hpp 100.00% <ø> (ø)
core/api/rpc/json.hpp 11.95% <ø> (ø)
core/api/types/tipset_context.hpp 0.00% <0.00%> (ø)
core/api/wallet/local_wallet.cpp 0.00% <0.00%> (ø)
core/node/main/builder.cpp 1.44% <0.00%> (-0.07%) :arrow_down:
core/api/full_node/node_api.hpp 100.00% <100.00%> (ø)
core/api/wallet/wallet_api.hpp 100.00% <100.00%> (ø)
core/vm/state/resolve_key.hpp 28.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f48a0cc...15d13a8. Read the comment docs.