search

filecoin-project / cpp-filecoin

C++17 implementation of Filecoin
https://filecoin.io/
GNU General Public License v3.0
126 stars 36 forks source link

FSM update - rules with the same events #623

Closed Alexey-N-Chernyshov closed 2 years ago

Alexey-N-Chernyshov commented 2 years ago

Signed-off-by: Alexey Chernyshov alexey.n.chernyshov@gmail.com

Description of the Change

FSM fix for rules with the same events: A -(event)-> B C -(event)-> D

The fix will be used in SnapDeals, for example: kWaitDeals - kAddPiece -> kWaitDeals kWaitSnapDeals - kAddPiece -> kWaitSnapDeals

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

codecov[bot] commented 2 years ago

Codecov Report

Merging #623 (d8fe460) into master (161a2b8) will increase coverage by 0.04%. The diff coverage is 83.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #623      +/-   ##
==========================================
+ Coverage   45.44%   45.48%   +0.04%     
==========================================
  Files         728      728              
  Lines       32770    32806      +36     
  Branches    18174    18191      +17     
==========================================
+ Hits        14893    14923      +30     
+ Misses      13520    13519       -1     
- Partials     4357     4364       +7
Impacted Files Coverage Δ
...storage/client/impl/storage_market_client_impl.cpp 57.70% <0.00%> (-0.27%) :arrow_down:
...re/markets/storage/provider/impl/provider_impl.cpp 61.76% <0.00%> (-0.25%) :arrow_down:
core/miner/storage_fsm/impl/sealing_impl.cpp 43.32% <75.00%> (-0.12%) :arrow_down:
core/fsm/fsm.hpp 76.79% <86.79%> (+3.87%) :arrow_up: