filecoin-project / eudico

lotus, but also other things
Other
19 stars 14 forks source link

[minor bug] Error in events change monitoring child checkpoint commitment #173

Closed adlrocha closed 2 years ago

adlrocha commented 2 years ago

There seems to be a minor bug that is causing that in every epoch a state change for subnets is detected causing triggerChange for child subnet commitment to be triggered as if a new child checkpoint was committed (when it is not actually the case).

https://github.com/filecoin-project/eudico/blob/fba4f41391b0f82524ab384f132a8b235bfd7428/chain/consensus/hierarchical/subnet/manager/events.go#L104

We don't do anything anymore so we can either fix this bug when a new child checkpoint is committed, so we can either fix the bug and show the log for child checkpoint commitment the right way, or directly remove this event listener (probably my personal preference).