filecoin-project / eudico

lotus, but also other things
Other
19 stars 14 forks source link

Remove `CrossMessage` field from `BlockMsg` #218

Closed adlrocha closed 2 years ago

adlrocha commented 2 years ago

While writing the spec, we realized the CrossMessage field is no longer needed in BlockMsg. Before having hierarchical addresses we didn't have a way to identify cross-net messages, and we had to differentiate them from plain subnet messages because they are executed differently. https://github.com/filecoin-project/eudico/blob/137c6ddc3c23e0ab776ec885c26c48c5b60b28ae/chain/types/blockmsg.go#L13

We can now identify cross-net messages in a block by simply looking at the Fromand To and checking if they are hierarchical addresses. Cross-net messages can be included in the SecpkMessages field of the BlockMsg.

This removes the need for backward-compatibility for BlockMsgs pre-hierarchical consensus (as explored in https://github.com/filecoin-project/eudico/pull/95)