search

filecoin-project / eudico

lotus, but also other things
Other
19 stars 14 forks source link

Initial reconfiguration mechanism for Mir #234

Closed dnkolegov closed 2 years ago

dnkolegov commented 2 years ago

This PR introduces the Mir reconfiguration mechanism.

It also fixes https://github.com/filecoin-project/eudico/issues/235

codecov-commenter commented 2 years ago

Codecov Report

Merging #234 (2e43571) into eudico (1ec25b3) will increase coverage by 3.43%. The diff coverage is 70.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           eudico     #234      +/-   ##
==========================================
+ Coverage   20.48%   23.91%   +3.43%     
==========================================
  Files         603      604       +1     
  Lines       65261    65664     +403     
==========================================
+ Hits        13369    15706    +2337     
+ Misses      49450    47165    -2285     
- Partials     2442     2793     +351
Impacted Files Coverage Δ
chain/consensus/hierarchical/gen/gen.go 0.00% <0.00%> (ø)
...ain/consensus/hierarchical/subnet/submgr/atomic.go 0.00% <ø> (ø)
...consensus/hierarchical/subnet/submgr/checkpoint.go 46.24% <ø> (+46.24%) :arrow_up:
chain/consensus/mir/logger.go 86.66% <0.00%> (-13.34%) :arrow_down:
chain/consensus/dummy/dummy.go 62.60% <53.84%> (+17.83%) :arrow_up:
chain/consensus/hierarchical/validator.go 61.17% <55.00%> (+3.72%) :arrow_up:
itests/kit/tools_eudico.go 55.32% <55.75%> (+24.46%) :arrow_up:
itests/kit/ensemble_eudico.go 69.38% <57.89%> (+10.26%) :arrow_up:
chain/consensus/platform/platform.go 62.50% <62.50%> (ø)
chain/consensus/mir/mine.go 66.30% <65.95%> (-3.70%) :arrow_down:
... and 105 more
adlrocha commented 2 years ago

@dnkolegov, do you mind looking at this before merging? We can look at it together if needed. Thanks :pray:

dnkolegov commented 2 years ago

@dnkolegov, do you mind looking at https://github.com/filecoin-project/eudico/issues/236#issuecomment-1227034717 before merging? We can look at it together if needed. Thanks 🙏

@adlrocha I ran tests 3 times via CI. No those data races so far.

adlrocha commented 2 years ago

Beautiful, @dnkolegov Then it looks like its fixed. We need to handle the redundancy between the subnet lock and the manager lock, but I will add an issue and we can add it in a future PR. Let's wait for @matejpavlovic's on the networking race, and feel free to merge if it not a big issue.

matejpavlovic commented 2 years ago

Sorry for the delay, responded to all comments now @dnkolegov and @adlrocha .

adlrocha commented 2 years ago

Ok, this was a tough one, but I think after removing those TODOs we are ready to merge, @dnkolegov. Amazing job leading this one! :pray: