filecoin-project / eudico

lotus, but also other things
Other
19 stars 14 forks source link

HC: Refine subnet join parameter #254

Closed sergefdrv closed 2 years ago

sergefdrv commented 2 years ago

Related Issues

https://github.com/adlrocha/hc-subnet-actor/issues/2

Proposed Changes

Introducing JoinParams to use in place of Validator in subnet Join method.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

codecov-commenter commented 2 years ago

Codecov Report

Merging #254 (ef27578) into eudico (856b61e) will increase coverage by 0.14%. The diff coverage is 71.42%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/filecoin-project/eudico/pull/254/graphs/tree.svg?width=650&height=150&src=pr&token=1iLTwZrR8U&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)](https://codecov.io/gh/filecoin-project/eudico/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) ```diff @@ Coverage Diff @@ ## eudico #254 +/- ## ========================================== + Coverage 23.94% 24.08% +0.14% ========================================== Files 608 608 Lines 65726 65741 +15 ========================================== + Hits 15738 15834 +96 + Misses 47197 47114 -83 - Partials 2791 2793 +2 ``` | [Impacted Files](https://codecov.io/gh/filecoin-project/eudico/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) | Coverage Δ | | |---|---|---| | [...in/consensus/hierarchical/actors/subnet/gen/gen.go](https://codecov.io/gh/filecoin-project/eudico/pull/254/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-Y2hhaW4vY29uc2Vuc3VzL2hpZXJhcmNoaWNhbC9hY3RvcnMvc3VibmV0L2dlbi9nZW4uZ28=) | `0.00% <0.00%> (ø)` | | | [...nsensus/hierarchical/actors/subnet/subnet\_state.go](https://codecov.io/gh/filecoin-project/eudico/pull/254/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-Y2hhaW4vY29uc2Vuc3VzL2hpZXJhcmNoaWNhbC9hY3RvcnMvc3VibmV0L3N1Ym5ldF9zdGF0ZS5nbw==) | `78.57% <ø> (ø)` | | | [chain/consensus/mir/utils.go](https://codecov.io/gh/filecoin-project/eudico/pull/254/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-Y2hhaW4vY29uc2Vuc3VzL21pci91dGlscy5nbw==) | `70.58% <0.00%> (ø)` | | | [...in/consensus/hierarchical/subnet/submgr/manager.go](https://codecov.io/gh/filecoin-project/eudico/pull/254/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-Y2hhaW4vY29uc2Vuc3VzL2hpZXJhcmNoaWNhbC9zdWJuZXQvc3VibWdyL21hbmFnZXIuZ28=) | `60.46% <64.70%> (-0.02%)` | :arrow_down: | | [...nsensus/hierarchical/actors/subnet/subnet\_actor.go](https://codecov.io/gh/filecoin-project/eudico/pull/254/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-Y2hhaW4vY29uc2Vuc3VzL2hpZXJhcmNoaWNhbC9hY3RvcnMvc3VibmV0L3N1Ym5ldF9hY3Rvci5nbw==) | `87.11% <100.00%> (+0.38%)` | :arrow_up: | | [chain/consensus/hierarchical/validator.go](https://codecov.io/gh/filecoin-project/eudico/pull/254/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-Y2hhaW4vY29uc2Vuc3VzL2hpZXJhcmNoaWNhbC92YWxpZGF0b3IuZ28=) | `57.64% <0.00%> (-3.53%)` | :arrow_down: | | [...consensus/hierarchical/subnet/submgr/checkpoint.go](https://codecov.io/gh/filecoin-project/eudico/pull/254/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-Y2hhaW4vY29uc2Vuc3VzL2hpZXJhcmNoaWNhbC9zdWJuZXQvc3VibWdyL2NoZWNrcG9pbnQuZ28=) | `45.66% <0.00%> (-0.58%)` | :arrow_down: | | [chain/messagepool/selection.go](https://codecov.io/gh/filecoin-project/eudico/pull/254/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-Y2hhaW4vbWVzc2FnZXBvb2wvc2VsZWN0aW9uLmdv) | `51.92% <0.00%> (-0.20%)` | :arrow_down: | | [chain/store/store.go](https://codecov.io/gh/filecoin-project/eudico/pull/254/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-Y2hhaW4vc3RvcmUvc3RvcmUuZ28=) | `47.66% <0.00%> (+0.16%)` | :arrow_up: | | ... and [12 more](https://codecov.io/gh/filecoin-project/eudico/pull/254/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) | |