Validator struct cleanup

sergefdrv commented 2 years ago

Related Issues

none

Proposed Changes

The Subnet field in the Validator structure contains duplicate information that can be easily obtained from the context. Since this structure in used as a part of the subnet actor state, it seems desirable to get rid of that duplication.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

[ ] All commits have a clear commit message.
[ ] The PR title is in the form of of <PR type>: <area>: <change being made>
- example: fix: mempool: Introduce a cache for valid signatures
- PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
- area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
[ ] This PR has tests for new functionality or change in behaviour
[ ] If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
[ ] CI is green

sergefdrv commented 2 years ago

@dnkolegov I decided to keep the validator string format as is because the code will anyway be re-implemented in Lotus.

dnkolegov commented 2 years ago

@dnkolegov I decided to keep the validator string format as is because the code will anyway be re-implemented in Lotus.

But the string contains "/root" subnet name and the Validator type doesn't. So it is not clear for a new reader. At least, let's add a comment.

sergefdrv commented 2 years ago

@dnkolegov I decided to keep the validator string format as is because the code will anyway be re-implemented in Lotus.

But the string contains "/root" subnet name and the Validator type doesn't. So it is not clear for a new reader. At least, let's add a comment.

Well, I better remove the subnet part from the string format then.

filecoin-project / eudico