search

filecoin-project / filecoin-ffi

C and CGO bindings for Filecoin's Rust libraries
Other
94 stars 136 forks source link

feat: add FFI_USE_CUDA_SUPRASEAL env variable (#425) #426

Closed vmx closed 9 months ago

vmx commented 9 months ago

Make it possible to build the FFI with SupraSeal enabled, which should lead to better performance during C2.

Stebalien commented 9 months ago

Wait for @arajasek before merging.

arajasek commented 9 months ago

I don't think we want this in 1.24.0. It's landed in master, so it'll go out in the next release?

vmx commented 9 months ago

We pushed hard to get this into 1.24. It was just accidentally not merged.

Stebalien commented 9 months ago

1.24 is the stable release, no new features land in stable releases.

This will be in 1.25 which will be released at the same time.

arajasek commented 9 months ago

^What @Stebalien said. Basically, 1.24.0 should be exactly what's in https://github.com/filecoin-project/filecoin-ffi/commits/release/lotus-v1.23.4, plus anything needed for SynthPoRep / nv21.

vmx commented 9 months ago

This will be in 1.25 which will be released at the same time.

Just to make sure I understand this correctly: whether this change is in 1.24 or 1.25, people will be able to enable this feature on the same day. The only difference is that they need to use 1.25 instead of 1.24, correct?

arajasek commented 9 months ago

This will be in 1.25 which will be released at the same time.

Just to make sure I understand this correctly: whether this change is in 1.24 or 1.25, people will be able to enable this feature on the same day. The only difference is that they need to use 1.25 instead of 1.24, correct?

Yes, that is correct.

vmx commented 9 months ago

Yes, that is correct.

Cool, I just wanted to make sure that feature gets in the hands of people as soon as possible, which is the case (I don't mind which version that is). Hence I'm closing his PR.