search

filecoin-project / filecoin-ffi

C and CGO bindings for Filecoin's Rust libraries
Other
94 stars 136 forks source link

feat: add support for Non-interactive PoRep #453

Closed vmx closed 3 weeks ago

vmx commented 2 months ago

This commit adds support for ni-porep.

Also Rust >= 1.70 is needed due to the dependency on home v0.5.9 and fix the corresponding new Clippy warnings.

This is only the Rust side of things, the Go parts are missing.

cryptonemo commented 2 months ago

This needs to be rebased on top of https://github.com/filecoin-project/filecoin-ffi/pull/450, not master

vmx commented 2 months ago

Also rebased on your branch.

vmx commented 2 months ago

I've rebased this PR and also adapted it to the fixed names.

cryptonemo commented 2 months ago

I think this needs to target feat/nv23 and not master. Sound correct, @rjan90?

rjan90 commented 2 months ago

I think this needs to target feat/nv23 and not master. Sound correct, @rjan90?

Yeah, that is correct. That branch was based off master today, so it should not cause any issues.

vmx commented 2 months ago

I've changed the base to feat/nv23.

BigLep commented 3 weeks ago

Just going through and looking at nv23-related open items. A few questions:

  1. Who should we set the assignee to?
  2. What is remaining?
  3. Who is expected to do the reviewing?
  4. Have we looked into the CI failures?
vmx commented 3 weeks ago
  1. Who should we set the assignee to?

In the past did the FilCrypto team the Rust side of things and then the Lotus team added the Go parts and merged it.

2. What is remaining?

The Go parts which are done at https://github.com/filecoin-project/filecoin-ffi/pull/456

3. Who is expected to do the reviewing?

For the Rust side of things, Elliptic Research, for the Go side I'd guess FilOz.

4. Have we looked into the CI failures?

I've pushed a new commit which should get things green.

vmx commented 3 weeks ago

I should've added that in the past the Go side (Lotus team) owned the merging of things of the FFI, the FilCrypto team was just contributing to the Rust side of things (@cryptonemo please correct me if I'm wrong).

BigLep commented 3 weeks ago

@vmx : thanks for the explanation on how the filecoin-ffi work has been traditionally handled. I expect some of that may need to be reevaluated or at least documented in light of groups like FilOz and Elliptic Research being separate companies now, but that can be thought through and handled later.

For now, given this just has the rust changes and Elliptic Research is the owner of those, I've assigned this issue to you. Please go ahead and merge when you have approval (✅ here) and all the rust changes are included. (It sounds like per Rod there is a small change to bring over.)

BigLep commented 3 weeks ago

I'm closing given superseded by https://github.com/filecoin-project/filecoin-ffi/pull/459