Closed rvagg closed 3 weeks ago
Got something funky going on with the gocheck2 .. on aarch it wants it as a GOEXPERIMENT=gocheck2, but Darwin and Linux builders don't recognise that. I'll have to figure that one out before this can be landed.
Specifically:
???
Ah: the aarch64 runner is "ubuntu-2204:current" while the others are cimg/go:1.20
. That latter one likely needs to be upgraded to go 1.21.
@rvagg : I know it's getting late your time. Will you be handling the CI issues discussed above before signing off, or are you expecting @rjan90 to?
Thanks to @vmx he has addressed the CI-issues above, and also consolidated the three different filecoin-ffi PRs related to NI-PoRep into https://github.com/filecoin-project/filecoin-ffi/pull/459
I'm closing given superseded by https://github.com/filecoin-project/filecoin-ffi/pull/459
~Some additional changes on top of a rebased https://github.com/filecoin-project/filecoin-ffi/pull/453, while I try and wire things up for integration testing.~
~This has local linking for ref-fvm for https://github.com/filecoin-project/ref-fvm/pull/1999 on top of master for https://github.com/filecoin-project/ref-fvm/pull/2009.~
~It also has local linking for rust-filecoin-proofs-api for https://github.com/filecoin-project/rust-filecoin-proofs-api/pull/103~
--
Additions on top of https://github.com/filecoin-project/filecoin-ffi/pull/453, but this depends on https://github.com/filecoin-project/go-state-types/pull/269 being merged.
Note that his also includes
seal_commit_phase2_circuit_proofs
inrust/src/proofs/api.rs
, that could go into #453.