search

filecoin-project / filecoin-fvm-localnet

A complete filecoin lotus and boost docker image to spin up a localnet for smart contract development
MIT License
13 stars 8 forks source link

ci: updated docker publish namespace #7

Closed galargh closed 1 year ago

galargh commented 1 year ago

This is a follow to the conversation we had during IPFS Thing. I noticed that we didn't update the image namespaces after the repo was migrated to filecoin-project org. The workflows are now failing because the GitHub token that we get doesn't have permission to publish to hammertoe account.

After the merge, the first runs for docker-compose-images-preproofs and docker-compose-images will fail because the updated Dockerfile references ghcr.io/filecoin-project/lotus-localnet-multiarch and ghcr.io/filecoin-project/boost-localnet-multiarch which will only come to existence when boost-localnet-multiarch and lotus-localnet-multiarch finish. If we don't want that to happen, we could split this PR in two - one which will only update the GHA workflows and a second one which will update the Dockerfile.

BTW, I've also made you the admin of this repo.

hammertoe commented 1 year ago

Awesome! Thank you for following up and working on this. Yes, it would be better to split into two different PRs so that we can first ensure the new build works (and the images work).