filecoin-project / filecoin-solidity

Filecoin Solidity API Library
Other
18 stars 12 forks source link

Refactor imports for contracts from `solidity-bignumber` external library #11

Closed andrejrakic closed 1 year ago

andrejrakic commented 1 year ago

Why

With the current setup, it can be confusing to developers where the imported contracts are coming from. One can misinterpret that solidity-bignumber contracts are coming from the external NPM package instead of from the local vendor folder if one doesn't check the remappings.txt file, which is a real possibility. Check this comment for reference.

What

How

For example, line 26 in MarketMockAPI.sol should become:

import "../../../vendor/solidity-BigNumber/src/BigNumbers.sol";

Who

@vonum

When

Milestone 1

BlocksOnAChain commented 1 year ago

is this ready for review from our side or still in active development? I didn't see any active PRs that are related, so I can't check on my own... @andrejrakic @vonum