actor-errors

[lordshashank]

• Fixes #3

resolving unconditional revert discussed in issue https://github.com/Zondax/filecoin-solidity/issues/363 . Defined error codes in new files and reverted them in actor.sol. Have defined actor errors only defined here. Tested it for deal expiration and non-existent deals. Any additional features and improvement in code is invited.

[vonum]

Hey @lordshashank looks good to me. Can we cover that with tests? Also, does it make sense to document those constants somewhere?

[lordshashank]

@vonum , I am not able to find any hardhat tests of library APIs in the repository, where should I add the tests?

all I can do is add a solidity file to test the errors here https://github.com/filecoin-project/filecoin-solidity/tree/master/contracts/v0.8/tests . Is that what you are asking, or we can make new tests folder in hardhat folder and do testing there.

[lordshashank]

Hey, the tests folder you stated is for rust tests. I would have to include solidity hardhat tests for this. There are no solidity tests in the repo. Could I make a new tests folder in ./hardhat folder for testing?

[wertikalk]

@lordshashank has asked a lot of good questions over slack and it is good that this information is widely known.

Most important questions in our discussion over slack:

• How are Hex constants in the integration tests created?
  • The hex string is formed by ABI encoding the call to the contract function, then adding a CBOR encoding in front of that string and then cutting away two first characters of the resulting string. In your example above (market.rs test) :
  • 5824 - CBOR part
  • F5C03658 - function selector for get_deal_activation
  • 00..000 - ABI encoded function parameter We are currently working on replacing this hardcoded strings with dynamically generated ones, but it's still work in progress. For debugging purposes, you can first generate ABI part and then use https://cbor.me/ to get the full string.
• How are you generating this in rust - is there any library?
  • Currently this is a work in progress, and we are using alloy-rs and its sol! macro. There's a draft PR that has some examples (see market.rs file).