Project refactoring proposal

[wertikalk]

Description

This is a list of our proposed major updates:

• Remove ./hardhat folder

  • This is an obsolete folder, and the scripts/code in them has never been useful/functional
    • Example: ./hardhat/deploy/market.js
    • The script deploys a solidity library (MarketAPI) and not a functional contract, and so no interaction is possible with it as contracts need to embedded library's code
    • Also, this withdraw-balance call from a corresponding task
      • the method's name is not originally correct - it should be withdrawBalance.
      • After renaming it (and updating RPC/Private key variables) it reasonably fails because only the library is deployed.
  • Remaining scripts/tasks contain similar logic

• Move the ./vendor folder to ./contracts/vendor

  • This will keep the project's root cleaner, and will help us with the release of filecoin-solidity's npm package

• Development/Release Version Flow

  • Introducing release branches with tags in the same way openzeppelin-contracts is structured. This will allow for a developer to install a specific version of the filecoin-solidity library.

We do not propose further extensive changes in the project at this time. Link to the original issue.

Affected issues

• Closes #9

[maciejwitowski]

This idea sounds good. I'm not familiar with the whole project though so would like to see other folks commenting on what else we could potentially include in the scope.

[wertikalk]

There was some kind of bug where github diff showed that some files were changed, but they weren't.

Closing this in favor of: https://github.com/filecoin-project/filecoin-solidity/pull/27