Closed vaniiiii closed 10 months ago
I think having constructors for common types is enough.
I'd suggest to have cidFromString
. Also, what about functions to create BigInt
and UniversalReceiverParams
(which also contain bytes
and may be hard to figure out for devs).
@vaniiiii any update here?
@vaniiiii any update here?
Hi @maciejwitowski,
BigInt
already has constructors/functions in ./utils/BigInts.sol that are able to convert from/to uint256
/int256
UniversalReceiverParams
UniversalReceiverParams
) as it is our understanding that this function on the filecoin actor wouldn't be called from the FEVM level and would only be called automatically when there is an asset transfer to that account. cidFromString
@vaniiiii I agree with all your points, thanks!
Description
This pull request proposes the required functionality related to issue #5
It will allow developers who integrate the filecoin-solidity library into their codebase to construct common Filecoin types. Some of the types are not intended to be created by developers, such as FailCode, BatchReturn, etc. For other common types like BigInt and FilAddress, there are already methods that allow conversion to these types.
Proposed functions
Affected issues