The MarketAPI.getDealTerm() method returns the start epoch and duration, but it stores the duration in the end field, which can be confusing and misrepresent the value.
Proposed changes
The proposed changes include either altering the struct field name to duration or modifying the functionality in getDealTerm() to accurately represent the end epoch value. Regardless of whether we choose to rename the field or modify the functionality, it's important to note that we will need to update relevant tests and affected files to align with this change.
Description
The pull request aims to address issue #26. The current definition of the
GetDealTermReturn
struct is as follows:The
MarketAPI.getDealTerm()
method returns the start epoch and duration, but it stores the duration in the end field, which can be confusing and misrepresent the value.Proposed changes
The proposed changes include either altering the struct field name to
duration
or modifying the functionality ingetDealTerm()
to accurately represent the end epoch value. Regardless of whether we choose to rename the field or modify the functionality, it's important to note that we will need to update relevant tests and affected files to align with this change.Affected issues