search

filecoin-project / filecoin-solidity

Filecoin Solidity API Library
Other
17 stars 11 forks source link

Issue #26 Proposal #30

Closed vaniiiii closed 9 months ago

vaniiiii commented 10 months ago

Description

The pull request aims to address issue #26. The current definition of the GetDealTermReturn struct is as follows:

struct GetDealTermReturn {
        ChainEpoch start;
        ChainEpoch end;
    }

The MarketAPI.getDealTerm() method returns the start epoch and duration, but it stores the duration in the end field, which can be confusing and misrepresent the value.

Proposed changes

The proposed changes include either altering the struct field name to duration or modifying the functionality in getDealTerm() to accurately represent the end epoch value. Regardless of whether we choose to rename the field or modify the functionality, it's important to note that we will need to update relevant tests and affected files to align with this change.

Affected issues

wertikalk commented 9 months ago

Closing in favor of: https://github.com/filecoin-project/filecoin-solidity/pull/39