search

filecoin-project / filecoin-solidity

Filecoin Solidity API Library
Other
17 stars 11 forks source link

Reduce the number of lib's custom structs #38

Closed wertikalk closed 7 months ago

wertikalk commented 9 months ago

Description

The main part of milestone-3 is to reduce the number of structs in favor of flat parameters (where it makes sense).

Approach

As every change to the current state would trigger an update through out the library (see https://github.com/filecoin-project/filecoin-solidity/issues/33), we limited ourselves to the most redundant structs (i.e. struct containing just a list of another struct type).

We have replaced the following structs with the corresponding flat parameters:

Affected issues

robertagora commented 9 months ago

This looks great but let's review what the conflicts are. Will follow up on this.

wertikalk commented 9 months ago

Conflict occurred because other PRs were merged into main and the changes weren't merged into this branch.

Will soon update this branch - until then, there's no need to review it.