filecoin-project / filecoin-solidity

Filecoin Solidity API Library
Other
17 stars 11 forks source link

[M4] combined updates after review #64

Closed wertikalk closed 2 months ago

wertikalk commented 2 months ago

Contains changes requested from PRs: #54 and #56.

Summary:

snissn commented 2 months ago

i switched the merge to target master and i'm pushing an empty commit to try to trigger the CI

wertikalk commented 2 months ago

@snissn the test issues :

Error: could not coalesce error (error={ "code": 1, "message": "failed to look up actor state nonce: resolution lookup failed (t410flhj4hu5a64fa3futegri35t6naug6cr3mdzmdii): resolve address t410flhj4hu5a64fa3futegri35t6naug6cr3mdzmdii: actor not found: validation failure" }, payload={ "id": 9, "jsonrpc": "2.0", "method": "eth_sendRawTransaction", "params": [ "..." ] }, code=UNKNOWN_ERROR, version=6.12.1)

were due to the filecoin delayed execution model as some contracts were not included in the chain's state once their methods were called, and so the failed to look up actor state nonce happened - pushed the fix.

snissn commented 2 months ago

Localhost tests are passing on the latest commit for me :+1: I just need the calibnet PK

# make test_hh_localnet
./lib-dev/dev-env/5_test-run-localnet.sh
Localnet setup done - Running tests ...

  Account Test
    ✔ Test 1: Integration test port (99399ms)

  Address Test
Deploying contracts... (AddressTest)
    ✔ Test 1: Integration test port (85050ms)

  BigInt Test
Deploying contracts... (BigIntsTest)
    ✔ Test 1: Integration test port (62815ms)

  CborDecode Test
    ✔ Test 1: Integration test port (85052ms)

  Datacap Test
    ✔ Test 1: Integration test port (99409ms)

  Deserialize Params Test
Deploying contracts... (DeserializeParamsTest)
    ✔ Test 1: Integration test port (80918ms)

  Leb128 Test
    ✔ Test 1: Integration test port

  Market Tests
    ✔ Test 1: Basic Deal Flow (174164ms)

  Market Cbot Test
Deploying contracts... (MarketCBORTest)
    ✔ Test 1: Integration test port (84769ms)

  Power Test
    ✔ Test 1: Integration test port (62975ms)

  Precompiles Test
    ✔ Test 1: Integration test port (67492ms)

  Send Test
    ✔ Test 1: Integration test port (121213ms)

  Verifreg Test
    ✔ Test 1: Integration test port (139675ms)

  Market Tests (Beacon)
    ✔ Test 1: Basic Deal Flow with Beacon Proxy Upgrade (202249ms)

  Market Tests (Transparent)
    ✔ Test 1: Basic Deal Flow with Transparent Proxy Upgrade (202056ms)

  Market Tests (UUPS)
    ✔ Test 1: Basic Deal Flow with UUPS Proxy Upgrade (180309ms)

  16 passing (29m)